[PATCH] D18494: ThinLTO: add module caching handling.

[Mehdi Amini via llvm-commits]

No, Not at all, thanks for checking!

Sent from my iPhone

> On Apr 13, 2016, at 9:15 AM, Teresa Johnson <tejohnson at google.com> wrote:
> 
> tejohnson added a comment.
> 
> Is this essentially done and ready for re-review? (Realize it is dependent on outstanding patch http://reviews.llvm.org/D18987.)
> 
> 
> ================
> Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:408
> @@ -312,2 +407,3 @@
> +    std::map<GlobalValue::GUID, GlobalValue::LinkageTypes> &ResolvedODR,
>     ThinLTOCodeGenerator::CachingOptions CacheOptions, bool DisableCodeGen,
>     StringRef SaveTempsDir, unsigned count) {
> ----------------
> Not directly related to this patch, but I just noticed that the CacheOptions parameter here is unused.
> 
> 
> http://reviews.llvm.org/D18494
> 
> 
>