[PATCH] D18693: [mips] Remove duplicate tests and add missing prefixes for *-LABEL checks. NFC.

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 08:43:02 PDT 2016


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM. Agreed, tests with a fixed zero operand are not useful in this case.

Some pre-existing labels are nit worthy though, I've highlighted them inline.


================
Comment at: test/CodeGen/Mips/llvm-ir/srem.ll:187
@@ -181,3 +186,3 @@
   ; GP64-NOT-R6:  ld      $25, %call16(__modti3)($gp)
   ; 64-R6:        ld      $25, %call16(__modti3)($gp)
 
----------------
Shouldn't this be 64R6?

================
Comment at: test/CodeGen/Mips/llvm-ir/urem.ll:215
@@ -209,3 +214,3 @@
   ; GP64-NOT-R6:  ld      $25, %call16(__umodti3)($gp)
   ; 64-R6:        ld      $25, %call16(__umodti3)($gp)
 
----------------
I know you haven't changed this, but shouldn't this be 64R6?


http://reviews.llvm.org/D18693





More information about the llvm-commits mailing list