[PATCH] D14390: [mips] Expansion of LI.S and LI.D

[Srdjan Obucina via llvm-commits]

obucina added inline comments.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:558
@@ -554,3 +557,3 @@
   /// Warn if RegIndex is the same as the current AT.
   void warnIfRegIndexIsAT(unsigned RegIndex, SMLoc Loc);
 
----------------
RegKind_FGR is removed because we didn't find another way to distinguish RegKind_GPR and RegKind_FGR in
li.s $4 1.12345 and li.s $f4 1.12345, for example. Actually, for $4 in llvm is created RegKind_Numeric register, that is defined as RegKind_Numeric = RegKind_GPR | RegKind_FGR | RegKind_FCC ..., so condition isFGRAsmReg() in validateOperandClass() function (in MipsGenAsmMatcher.inc) is true for $4 and we get the expansion for RegKind_FGR instead of RegKind_GPR.


http://reviews.llvm.org/D14390