[PATCH] D19053: [LNT] Some more docs for the LNT json file format.

[James Greenhalgh via llvm-commits]

jgreenhalgh added a subscriber: jgreenhalgh.

================
Comment at: docs/concepts.rst:63-65
@@ -62,5 +62,5 @@
 
 Any program can submit results data to LNT, and specify any test suite.  The
 data format is a simple JSON file, and that file needs to be HTTP POSTed to the
 submitRun URL.
 
----------------
Or use the lnt import command line tool.

================
Comment at: docs/importing_data.rst:17
@@ +16,3 @@
+format::
+
+  {
----------------
I would prefer a formal specification alongside this example data. As you'll see from the rest of the review - using just the sample text leaves some things ambiguous.

================
Comment at: docs/importing_data.rst:25-26
@@ +24,4 @@
+     "Run": {
+        "End Time": "2016-04-07 14:25:52",
+        "Start Time": "2016-04-07 09:33:48",
+        "Info": {
----------------
It is worth pointing out that the date *must* be in "%Y-%m-%d %H:%M:%S" format. I tripped up on this trying to use dates in the format in which I had recorded them.

================
Comment at: docs/importing_data.rst:29
@@ +28,3 @@
+          "run_order": "265649",
+          "tag": "nts"
+        }
----------------
You could mention that arbitrary String->String fields can be added here, and will be displayed in the Run Info in the interface.

================
Comment at: docs/importing_data.rst:52
@@ +51,3 @@
+              "Info": {},
+              "Name": "nts.suite1/program1.exec"
+          }
----------------
What is the difference between adding a seperate test with the same name, and adding multiple data items to "Data"?


http://reviews.llvm.org/D19053