[PATCH] D18999: [ELF/LTO] Parallel Codegen for LLD

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 18:24:10 PDT 2016


davide added inline comments.

================
Comment at: ELF/LTO.cpp:165
@@ +164,3 @@
+std::vector<std::unique_ptr<InputFile>> BitcodeCompiler::runSplitCodegen() {
+  size_t NumThreads = 1;
+  OwningData.resize(NumThreads);
----------------
ruiu wrote:
> Because NumThreads is 1, nothing would run in parallel?
Yes, I have another patch to add an option to specify the number of threads. I put this up to review to understand if the logic is sound. 
I'm collecting numbers in multiple configurations (1,2,3,4 threads). 
The previous comments in the review have some very early numbers using 4 threads.

Cheers,

--
Davide


http://reviews.llvm.org/D18999





More information about the llvm-commits mailing list