[PATCH] D18869: AArch64: Use a callee save registers for swiftself parameters

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Matthias,

Same comment as http://reviews.llvm.org/D18902 + some questions on the test cases.

Cheers,
-Quentin


================
Comment at: test/CodeGen/AArch64/swiftself.ll:40
@@ +39,3 @@
+; OPT: ret
+define void @swiftself_passthrough(i8* swiftself %addr0) {
+  call i8 *@swiftself_param(i8* swiftself %addr0)
----------------
Is it intended that we just check the label for O0?

================
Comment at: test/CodeGen/AArch64/swiftself.ll:49
@@ +48,3 @@
+; OPT: b {{_?}}swiftself_param
+; OPT-NOT: ret
+define i8* @swiftself_tail(i8* swiftself %addr0) {
----------------
Ditto.

================
Comment at: test/CodeGen/AArch64/swiftself.ll:59
@@ +58,3 @@
+; CHECK-LABEL: swiftself_notail:
+; CHECK: bl {{_?}}swiftself_param
+; CHECK: ret
----------------
Check that addr1 is properly copied into x20 from x1?


Repository:
  rL LLVM

http://reviews.llvm.org/D18869