[PATCH] D18625: [Speculation] Add a SpeculativeExecution mode where the pass does nothing unless TTI::hasBranchDivergence() is true.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 15:06:11 PDT 2016


jlebar added a comment.

Thank you for the review, Chandler!


================
Comment at: test/Transforms/SpeculativeExecution/divergent-target.ll:7
@@ +6,3 @@
+
+target triple = "nvptx-nvidia-cuda"
+
----------------
chandlerc wrote:
> Maybe put this in '-mtriple' arguments to the two target specific ones? That way the "always" mode isn't tied to this target?
> 
> It would also make the '-march' above more clean as it could be a parallel '-mtriple=x86_64-...'
Much better, thanks.  I'd been trying -mcpu and -march, but that didn't work, and I didn't look closely enough at opt.cpp to see that -mtriple would do the same.


http://reviews.llvm.org/D18625





More information about the llvm-commits mailing list