Untested code
Rafael EspĂndola via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 12 14:02:43 PDT 2016
>>> Could you try adding tests for it?
>>
>> OK. Will do.
>
> Done at r266119
Awesome!
I think now there is only one if left untested (see the attached patch) :-)
Cheers,
Rafael
-------------- next part --------------
diff --git a/ELF/InputSection.cpp b/ELF/InputSection.cpp
index ba77b3e..b03c777 100644
--- a/ELF/InputSection.cpp
+++ b/ELF/InputSection.cpp
@@ -208,8 +208,6 @@ static uintX_t adjustMipsSymVA(uint32_t Type, const elf::ObjectFile<ELFT> &File,
uintX_t SymVA) {
if (Type == R_MIPS_HI16 && &Body == ElfSym<ELFT>::MipsGpDisp)
return SymVA - AddrLoc;
- if (Type == R_MIPS_LO16 && &Body == ElfSym<ELFT>::MipsGpDisp)
- return SymVA - AddrLoc + 4;
if (Body.isLocal() && (Type == R_MIPS_GPREL16 || Type == R_MIPS_GPREL32))
// We need to adjust SymVA value in case of R_MIPS_GPREL16/32
// relocations because they use the following expression to calculate
More information about the llvm-commits
mailing list