[PATCH] Fix a couple of use-after-frees in X86ISelDAGToDAG

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 12:43:39 PDT 2016


Looks like the only uses are DL/VT; maybe just get those earlier (and
explain in a comment)?

Also, I thought SelectionDAGISel.cpp had the same issues.  You do
mention ISD::DELETED_NODE in the PR; I guess you have a plan to get
rid of that?
-Ahmed


On Tue, Apr 12, 2016 at 11:14 AM, Justin Bogner <mail at justinbogner.com> wrote:
> While looking at llvm.org/PR26808 I found a couple of use-after-frees in
> X86ISelDAGToDAG, where we RAUW a node and then try to keep using it. The
> attached patch fixes the tests that crash under ASan, but it feels a bit
> targetted and kludgy. I'm afraid a robust fix would involve a lot of
> refactoring of how X86ISelDAGToDAG works though, and I certainly won't
> be able to do that any time soon.
>
> Thoughts?
>


More information about the llvm-commits mailing list