[PATCH] D19013: [DivergenceAnalysis] Treat PHI with incoming undef as constant
Jingyue Wu via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 12 10:12:46 PDT 2016
jingyue accepted this revision.
jingyue added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: lib/IR/Instructions.cpp:160
@@ +159,3 @@
+/// non-undefs.
+/// Unlike \ref hasConstantValue, this does not return a value because the
+/// unique non-undef incoming value need not dominate the PHI node.
----------------
two spaces => one space
================
Comment at: test/CodeGen/AMDGPU/branch-uniformity.ll:19
@@ +18,3 @@
+
+LOOP: ; preds = %ENDLOOP48, %main_body
+ %counter = phi i32 [ 0, %main_body ], [ %counter.next, %ENDLOOP48 ]
----------------
Traditionally, basic block names are lower-case.
http://reviews.llvm.org/D19013
More information about the llvm-commits
mailing list