[PATCH] D18625: [Speculation] Add a SpeculativeExecution mode where the pass does nothing unless TTI::hasBranchDivergence() is true.
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 12 09:22:04 PDT 2016
jlebar added a comment.
> Please add a pass-local flag that allows you to test the pass in both modes, and some test cases exercising the behavior here.
Chandler, how would you feel if I added a test to http://reviews.llvm.org/D18626 instead? (The test would check that we do the speculative execution only on the appropriate targets.)
Adding a flag to force speculative execution on (or off?) doesn't seem to test what we're actually after, namely that we do SpeculativeExecution iff the target has divergent branches.
http://reviews.llvm.org/D18625
More information about the llvm-commits
mailing list