[PATCH] D18995: [mips] Fix emitAtomicCmpSwapPartword to handle 64 bit pointers correctly

Matthew Fortune via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 09:16:08 PDT 2016


mpf added a subscriber: mpf.
mpf added a comment.

The changes in this patch look like they go too far. The issue was about pointer size not integer size. The only pseudo that needs to be i64 is alignedaddr when pointers are 64-bit and the only operation that needed to change was the AND that calculates alignedaddr. The rest should (and I believe must) stay as i32 as the values are used alongside LL/SC which operate on i32 types none of the data in this code exceeds 32-bit as it is all about sub-word operations.


http://reviews.llvm.org/D18995





More information about the llvm-commits mailing list