[PATCH] D17898: Implement expansion of {s, u}{min, max} in integer legalization

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 08:56:29 PDT 2016


arsenm added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1671-1673
@@ -1665,1 +1670,5 @@
 
+static void GetMINMAXOps(unsigned int Op, llvm::ISD::NodeType &LoOp,
+                         llvm::ISD::CondCode &Cond)
+{
+  switch (Op) {
----------------
Capitalization wrong: getMinMaxOps, brace should be on same line.

Should return the CondCode instead of assign and break which


Repository:
  rL LLVM

http://reviews.llvm.org/D17898





More information about the llvm-commits mailing list