[PATCH] D18861: [CLANG][AVX512][BUILTIN] Completing and Adding scalar Intrinsics to clang

[Asaf Badouh via llvm-commits]

AsafBadouh added inline comments.

================
Comment at: lib/Headers/avx512fintrin.h:4356
@@ +4355,3 @@
+ return (__m128) __builtin_ia32_vfmaddss3_maskz ((__v4sf) __A,
+          (__v4sf) __B,
+          (__v4sf) __C,
----------------
I think it should be (__v4sf) (-(__B))

================
Comment at: lib/Headers/avx512fintrin.h:4364
@@ +4363,3 @@
+__builtin_ia32_vfmaddss3_maskz ((__v4sf) __A,\
+          (__v4sf) __B,\
+          (__v4sf) __C,\
----------------
same
I think it should be (__v4sf) (-(__B))

================
Comment at: lib/Headers/avx512fintrin.h:4409
@@ +4408,3 @@
+{
+ return (__m128) __builtin_ia32_vfmaddss3_maskz ((__v4sf) -__A,
+          (__v4sf) __B,
----------------
please add round parentheses to __A

================
Comment at: lib/Headers/avx512fintrin.h:4479
@@ +4478,3 @@
+static __inline__ __m128 __DEFAULT_FN_ATTRS
+_mm_mask3_fnmsub_ss (__m128 __W, __m128 __X, __m128 __Y, __mmask8 __U) 
+{
----------------
some "-" are missing

================
Comment at: lib/Headers/avx512fintrin.h:4571
@@ +4570,3 @@
+{
+ return (__m128) __builtin_ia32_vfmaddsd3_maskz ( (__v2df) __A,
+          (__v2df) __B,
----------------
some "-" is missing

================
Comment at: lib/Headers/avx512fintrin.h:4579
@@ +4578,3 @@
+#define _mm_maskz_fmsub_round_sd( __U, __A, __B, __C, __R) __extension__ ({\
+__builtin_ia32_vfmaddsd3_maskz ( (__v2df) __A,\
+          (__v2df) __B,\
----------------
some "-" is missing


================
Comment at: lib/Headers/avx512fintrin.h:4660
@@ +4659,3 @@
+{
+ return (__m128) __builtin_ia32_vfmaddsd3_mask ( (__v2df) -(__A),
+          (__v2df) __B,
----------------
I'm not sure but I think it should be:
 (__v2df) (__A),
 (__v2df) -(__B),
 (__v2df) -(__W),



http://reviews.llvm.org/D18861