[PATCH] D18994: [LTO] Switch Module to std::unique_ptr<>

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 15:36:50 PDT 2016


On Mon, Apr 11, 2016 at 3:34 PM, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> ruiu accepted this revision.
> ruiu added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
>
>
> ================
> Comment at: ELF/LTO.h:43
> @@ +42,3 @@
> +  BitcodeCompiler()
> +      : Combined(new llvm::Module("ld-temp.o", Context)), Mover(*Combined){};
> +
> ----------------
> Need a space before {}. (Or run clang-format-diff.)
>

I ran clang-format -i and it doesn't put the space.

Cheers,

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list