[PATCH] D18934: post-commit patch review for r265547

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 15:35:49 PDT 2016


wmi added inline comments.

================
Comment at: lib/CodeGen/InlineSpiller.cpp:1276
@@ +1275,3 @@
+      if (SpillsInSubTreeMap.find(Child) == SpillsInSubTreeMap.end())
+        continue;
+      // SpillsInSubTreeMap[*RIt].second += SpillsInSubTreeMap[Child].second
----------------
qcolombet wrote:
> Since we make sure not to create an entry for Child, I believe it is safe to SpillsInSubTreeMap[*RIt] in a local variable.
> That should make the code a but more readable.
Will fix it in the next commit.


Repository:
  rL LLVM

http://reviews.llvm.org/D18934





More information about the llvm-commits mailing list