[PATCH] D18813: Update visibility settings for CFI tests.

[Peter Collingbourne via llvm-commits]

pcc updated this revision to Diff 53333.
pcc added a comment.

- Address review comment


http://reviews.llvm.org/D18813

Files:
  test/cfi/lit.cfg

Index: test/cfi/lit.cfg
===================================================================
--- test/cfi/lit.cfg
+++ test/cfi/lit.cfg
@@ -11,16 +11,16 @@
 config.substitutions.append((r"%clangxx ", clangxx + ' '))
 if config.lto_supported:
   clang_cfi = ' '.join(config.lto_launch + [config.clang] + config.lto_flags + ['-flto -fsanitize=cfi '])
-  clangxx_cfi = clang_cfi + ' '.join(config.cxx_mode_flags) + ' '
-  diag_flags = '-fno-sanitize-trap=cfi -fsanitize-recover=cfi '
-  clang_cfi_diag = clang_cfi + diag_flags
-  clangxx_cfi_diag = clangxx_cfi + diag_flags
-  config.substitutions.append((r"%clang_cfi ", clang_cfi))
-  config.substitutions.append((r"%clangxx_cfi ", clangxx_cfi))
-  config.substitutions.append((r"%clang_cfi_diag ", clang_cfi_diag))
-  config.substitutions.append((r"%clangxx_cfi_diag ", clangxx_cfi_diag))
-  config.substitutions.append((r"%clangxx_cfi_dso ", clangxx_cfi + '-fsanitize-cfi-cross-dso '))
-  config.substitutions.append((r"%clangxx_cfi_dso_diag ", clangxx_cfi_diag + '-fsanitize-cfi-cross-dso '))
+  cxx = ' '.join(config.cxx_mode_flags) + ' '
+  diag = '-fno-sanitize-trap=cfi -fsanitize-recover=cfi '
+  non_dso = '-fvisibility=hidden '
+  dso = '-fsanitize-cfi-cross-dso -fvisibility=default '
+  config.substitutions.append((r"%clang_cfi ", clang_cfi + non_dso))
+  config.substitutions.append((r"%clangxx_cfi ", clang_cfi + cxx + non_dso))
+  config.substitutions.append((r"%clang_cfi_diag ", clang_cfi + non_dso + diag))
+  config.substitutions.append((r"%clangxx_cfi_diag ", clang_cfi + cxx + non_dso + diag))
+  config.substitutions.append((r"%clangxx_cfi_dso ", clang_cfi + cxx + dso))
+  config.substitutions.append((r"%clangxx_cfi_dso_diag ", clang_cfi + cxx + dso + diag))
 else:
   config.unsupported = True
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18813.53333.patch
Type: text/x-patch
Size: 1769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160411/4e44c960/attachment.bin>