[PATCH] D18936: Fix regalloc-verifier error for r265547
Wei Mi via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 14:36:45 PDT 2016
wmi added inline comments.
================
Comment at: lib/CodeGen/LiveRangeEdit.cpp:166
@@ -151,1 +165,3 @@
+ if (isDeadRemat)
+ RM.OrigMI->getOperand(0).setIsDead(true);
Rematted.insert(RM.ParentVNI);
----------------
qcolombet wrote:
> This code feels so wrong.
> I am okay if we would have to reset isDead to false for DestReg, since the remat may just clone the input, but we shouldn’t have to do a gymnastic with OrigMI.
Yes, you are right. It is better to just reset isDead to false for DestReg of the instruction cloned by remat.
Repository:
rL LLVM
http://reviews.llvm.org/D18936
More information about the llvm-commits
mailing list