thanm added a comment. Hi Quentin, Haven't run clang-format. Would it make sense to run afterwards, so as to not mix up pure formatting changes with functional changes? I am ok either way, just not sure what the best practice is. Thanks, Than http://reviews.llvm.org/D18827