[PATCH] D18716: Swift Calling Convention: target-specific changes

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 13:22:58 PDT 2016


qcolombet accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: test/CodeGen/AArch64/swifterror.ll:8
@@ +7,3 @@
+
+; This tests the basic usage of a swifterror parameter. "foo" is the function
+; that takes a swifterror parameter and "caller" is the caller of "foo".
----------------
tests -> test

================
Comment at: test/CodeGen/AArch64/swifterror.ll:36
@@ +35,3 @@
+
+define float @caller(i8* %error_ref) {
+; CHECK-APPLE-LABEL: caller:
----------------
Could you add a description for the test?

================
Comment at: test/CodeGen/AArch64/swifterror.ll:249
@@ +248,3 @@
+
+define float @caller3(i8* %error_ref) {
+; CHECK-APPLE-LABEL: caller3:
----------------
Missing description.

================
Comment at: test/CodeGen/AArch64/swifterror.ll:339
@@ +338,3 @@
+
+define float @caller4(i8* %error_ref) {
+; CHECK-APPLE-LABEL: caller4:
----------------
Description.


http://reviews.llvm.org/D18716





More information about the llvm-commits mailing list