[PATCH] D18875: NFC: unify clang / LLVM atomic ordering

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 13:03:12 PDT 2016


jfb added inline comments.

================
Comment at: include/llvm/Support/AtomicOrdering.h:23-34
@@ +22,14 @@
+
+/// Atomic ordering for C11 / C++11's memody models.
+///
+/// These values cannot change because they are shared with standard library
+/// implementations as well as with other compilers.
+enum class AtomicOrderingCABI {
+  relaxed = 0,
+  consume = 1,
+  acquire = 2,
+  release = 3,
+  acq_rel = 4,
+  seq_cst = 5,
+};
+
----------------
rsmith wrote:
> Why does LLVM need to know about these? It seems like they're specific to the frontend. Is there some way in which they're not? (Is some upcoming change going to use these from LLVM?)
> 
> What happens if some C ABI picks different values?
See this patch by @jyknight: http://reviews.llvm.org/D18200#inline-151433


http://reviews.llvm.org/D18875





More information about the llvm-commits mailing list