[PATCH] D18946: ThinLTO renaming: use module hash instead of position in the summary
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 13:02:16 PDT 2016
tejohnson added a subscriber: pcc.
tejohnson added a reviewer: pcc.
tejohnson added a comment.
Adding pcc since this is different than his proposal to use a hash of external names in order to facilitate renaming in the compile step (and thus enable compiling some code to text early).
I think for now this is ok, as it is better than the current strategy with regards to link ordering effects, even if we want to eventually migrate to using the hash of external names.
One thing to note is that the module hash will itself need to change if pcc implements compiling some portions to text early, to ensure that the hash reflects differences in the non-bitcode portion.
http://reviews.llvm.org/D18946
More information about the llvm-commits
mailing list