[PATCH] D18716: Swift Calling Convention: target-specific changes

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Manman,

I haven’t checked all the places, but I think you should have access to TLI through the MachineFunction then the sub target everywhere.

Cheers,
-Quentin


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:713
@@ +712,3 @@
+  return Subtarget.isTargetMachO() &&
+         !Attrs.hasAttrSomewhere(Attribute::SwiftError);
+}
----------------
You should have access to it through the sub target you get from the function.

================
Comment at: lib/Target/AArch64/AArch64RegisterInfo.cpp:56
@@ -54,1 +55,3 @@
+      Attribute::SwiftError))
+    return CSR_AArch64_AAPCS_SwiftError_SaveList;
   if (MF->getFunction()->getCallingConv() == CallingConv::PreserveMost)
----------------
MF->getSubtarget()->getTargetLowering().

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2304
@@ -2285,2 +2303,3 @@
+    SDValue Val = DAG.getCopyFromReg(RetOps[0], dl, SRetReg,
                                      getPointerTy(MF.getDataLayout()));
 
----------------
The comment helps :).


http://reviews.llvm.org/D18716