[PATCH] D18964: LLVM C API. Deprecated functions

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 11:34:41 PDT 2016


I actually think it can just be included. It doesn't include any other
files and seems to be C only.

-eric

On Mon, Apr 11, 2016 at 11:30 AM Alex Denisov <1101.debian at gmail.com> wrote:

> AlexDenisov added a comment.
>
> In http://reviews.llvm.org/D18964#397364, @echristo wrote:
>
> > We do already have a place, but I wasn't sure whether or not we wanted a
> >  separate implementation.
>
>
> This is exactly my intention. I copied the definition from
> `llvm/Support/Compiler.h`, but besides that it contains a lot of other
> stuff, that might not be suitable for C API (e.g. sanitizers).
> Another possible solution is to introduce another header and include it
> into both `llvm/Support/Compiler.h` and C API interface.
>
> > Also sometimes we keep alive some C++ APIs just for the purpose of
> supporting a C API, I think we should mark these as deprecated as well so
> we know we can remove them.
>
>
> This is a very good idea, I will skim through the implementations and
> check whether we can deprecate something there.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18964
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160411/8b7a050d/attachment.html>


More information about the llvm-commits mailing list