[PATCH] D18711: Change how we apply rellocations

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.cpp:264
@@ +263,3 @@
+
+  switch (Expr) {
+  case Relocation::R_ABS:
----------------
This function can be separated into three parts: the first switch-case, the middle `if`s to adjust SymVA for special cases, and the last switch-case.

Looks like in most cases you can return from this function from the first switch-case. Why don't you do that?

================
Comment at: ELF/InputSection.h:28
@@ +27,3 @@
+struct Relocation {
+  enum RelExpr {
+    R_ABS,
----------------
So you think that that's not a good idea?


http://reviews.llvm.org/D18711