[PATCH] D17068: [mips][microMIPS] Fix for "Cannot copy registers" assertion

Hrvoje Varga via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 00:17:54 PDT 2016


hvarga removed rL LLVM as the repository for this revision.
hvarga updated this revision to Diff 53196.
hvarga added a comment.
Herald added a subscriber: sdardis.

It is discovered that `test-suite` in case of microMIPS is failing after committing this patch into mainline. test.log contained error messages like:

  /tmp/ConditionalExpr-b127f7.s: Assembler messages:
  /tmp/ConditionalExpr-b127f7.s:487: Error: invalid operands `lw16 $4,0($1)'
  /tmp/ConditionalExpr-b127f7.s:489: Error: invalid operands `sw16 $4,0($1)'

I found out that i forgot to change MipsRegisterInfo::getPointerRegClass() in order to support GPRMM16 and GPRMM16_64 register classes. After this fix, manual execution of `test-suite` is passing. So please, review this change once again.


http://reviews.llvm.org/D17068

Files:
  lib/Target/Mips/MicroMipsInstrInfo.td
  lib/Target/Mips/MipsMachineFunction.cpp
  lib/Target/Mips/MipsRegisterInfo.cpp
  lib/Target/Mips/MipsRegisterInfo.td
  test/CodeGen/Mips/invalid_operands.ll
  test/CodeGen/Mips/micromips-addiu.ll
  test/CodeGen/Mips/micromips-andi.ll
  test/CodeGen/Mips/micromips-gp-rc.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17068.53196.patch
Type: text/x-patch
Size: 7550 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160411/e1b447a6/attachment.bin>


More information about the llvm-commits mailing list