[PATCH] D18945: [ThinLTO] Only compute imports for current module in FunctionImport pass

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 10 14:09:41 PDT 2016


joker.eph added a comment.

About your note: `ComputeCrossModuleImport()` *is* the API I am calling in the Thin-link step.

The export list is gonna be needed to drive a "smart" promotion/renaming, so I expect it to be needed at the same stage you need the import list. 
What will be the need for this?


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:313
@@ +312,3 @@
+    }
+  }
+
----------------
Should be refactored with `ModuleSummaryIndex::collectDefinedFunctionsPerModule()` after D18908, the code looks close.


http://reviews.llvm.org/D18945





More information about the llvm-commits mailing list