[PATCH] D18926: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512, psllv{16si|8di}, psra{d|q}512, psrav{16si|8di}, pternlog{d|q}{128|256|512} ) builtin to clang ...

[Asaf Badouh via llvm-commits]

AsafBadouh added a comment.

there are duplication in the headers and in the tests.


================
Comment at: lib/Headers/avx512fintrin.h:4345
@@ +4344,3 @@
+})
+
+#define _mm512_maskz_ternarylogic_epi32( __U, __A, __B, __C, imm) __extension__ ({ \
----------------
duplication 

================
Comment at: lib/Headers/avx512vlintrin.h:6408
@@ +6407,3 @@
+
+#define _mm256_maskz_ternarylogic_epi32( __U, __A, __B, __C, imm) __extension__ ({ \
+__builtin_ia32_pternlogd256_maskz ((__v8si)( __A),\
----------------
I think this definition is identical to line 6416

================
Comment at: lib/Headers/avx512vlintrin.h:6446
@@ +6445,3 @@
+
+#define _mm_maskz_ternarylogic_epi64( __U, __A, __B, __C, imm) __extension__ ({ \
+__builtin_ia32_pternlogq128_maskz ((__v2di)( __A),\
----------------
same

================
Comment at: test/CodeGen/avx512f-builtins.c:2812
@@ +2811,3 @@
+}
+
+__m512i test_mm512_maskz_ternarylogic_epi32(__mmask16 __U, __m512i __A, __m512i __B, __m512i __C) {
----------------
same tests (line 2807 and 2813)

================
Comment at: test/CodeGen/avx512f-builtins.c:2836
@@ +2835,3 @@
+}
+
+__m512i test_mm512_maskz_ternarylogic_epi64(__mmask8 __U, __m512i __A, __m512i __B, __m512i __C) {
----------------
same tests (line 2831 and 2837)

================
Comment at: test/CodeGen/avx512vl-builtins.c:4316
@@ +4315,3 @@
+}
+
+__m128i test_mm_maskz_ternarylogic_epi32(__mmask8 __U, __m128i __A, __m128i __B, __m128i __C) {
----------------
same tests

================
Comment at: test/CodeGen/avx512vl-builtins.c:4340
@@ +4339,3 @@
+}
+
+__m256i test_mm256_maskz_ternarylogic_epi32(__mmask8 __U, __m256i __A, __m256i __B, __m256i __C) {
----------------
same

================
Comment at: test/CodeGen/avx512vl-builtins.c:4364
@@ +4363,3 @@
+}
+
+__m128i test_mm_maskz_ternarylogic_epi64(__mmask8 __U, __m128i __A, __m128i __B, __m128i __C) {
----------------
same

================
Comment at: test/CodeGen/avx512vl-builtins.c:4389
@@ +4388,3 @@
+
+__m256i test_mm256_ternarylogic_epi64(__m256i __A, __m256i __B, __m256i __C) {
+  // CHECK-LABEL: @test_mm256_ternarylogic_epi64
----------------
duplication till the EOF


http://reviews.llvm.org/D18926