[PATCH] D17584: Cleanup inline cost analysis code

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 15:51:21 PDT 2016


eraman added a comment.

In http://reviews.llvm.org/D17584#393215, @davidxl wrote:

> Sorry for the long delay.
>
> Easwaran, please split the patches into smaller ones.
>
> 1. check in the refactoring code (allowSizeGrowth) -- no further review is required


Checkd in this part. This actually fixes the issue Akira had because you won't end up with a positive bonus, but an initial zero threshold. But the complex control flow means there could be other unintended results.

> 2. split out another NFC clean-up code (i.e. removal of IsRecursiveCall etc at line 1328)

> 3. the remaining changes.



http://reviews.llvm.org/D17584





More information about the llvm-commits mailing list