[PATCH] D18226: Codegen: Tail-duplicate during placement.

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 14:43:40 PDT 2016


sunfish added a subscriber: sunfish.

================
Comment at: test/CodeGen/WebAssembly/cfg-stackify.ll:2
@@ -1,3 +1,3 @@
 ; RUN: llc < %s -asm-verbose=false -disable-block-placement -verify-machineinstrs | FileCheck %s
-; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck -check-prefix=OPT %s
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -tail-dup-placement=0 | FileCheck -check-prefix=OPT %s
 
----------------
jfb wrote:
> Disabling tail duplication for WebAssembly sounds like a good approach. Fallthrough and code increase is likely not desirable for us in most cases.
Actually, we do care about fallthrough and tail duplication.

However, cfg-stackify.ll is a particularly tricky testcase, so I'm ok with this change as a workaround for now; we'll take a look and update the test later.


http://reviews.llvm.org/D18226





More information about the llvm-commits mailing list