[PATCH] D18908: ThinLTO: Move the ODR resolution to be based purely on the summary.
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 8 14:33:19 PDT 2016
tejohnson added a comment.
Just took a quick initial scan, one typo issue throughout: s/ResolvedORD/ResolvedODR/.
Also, what is the main gist of this change? The old code is refactored but it isn't immediately obvious to me what is different about the end state.
================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:170
@@ -176,1 +169,3 @@
+ StringRef ModuleIdentifier,
+ DenseMap<GlobalValue::GUID, GlobalValue::LinkageTypes> &ResolvedORD) {
// We won't optimize the globals that are referenced by an alias for now
----------------
typo: ResolvedORD ->ResolvedODR
http://reviews.llvm.org/D18908
More information about the llvm-commits
mailing list