[PATCH] D17736: [SSP] Remove llvm.stackprotectorcheck.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 13:50:17 PDT 2016


timshen added inline comments.

================
Comment at: include/llvm/Target/TargetLowering.h:1016
@@ -1015,4 +1015,3 @@
   /// returns the address of that location. Otherwise, returns nullptr.
-  virtual Value *getStackCookieLocation(IRBuilder<> &IRB) const {
-    return nullptr;
-  }
+  /// Returning nullptr means to use SelectionDAG SSP handling.
+  virtual Value *getIRStackGuard(IRBuilder<> &IRB) const;
----------------
eugenis wrote:
> This comment makes it sound like this function makes the decision to use SDAG vs IR stack protector.
> 
Moved the comment to StackProtector::CreatePrologue. At that point I was not aware that other code will use this function.


http://reviews.llvm.org/D17736





More information about the llvm-commits mailing list