[PATCH] D18836: Make aliases explicit in the module summary

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 12:18:00 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:2955
@@ -2960,3 +2954,3 @@
     WriteModuleLevelReferences(G, Index, VE, NameVals, FSModRefsAbbrev, Stream);
   for (const GlobalAlias &A : M->aliases())
     if (auto *GV = dyn_cast<GlobalVariable>(A.getBaseObject()))
----------------
I think this loop should be removed? Doesn't the new FS_ALIAS support apply to references as well?


http://reviews.llvm.org/D18836





More information about the llvm-commits mailing list