[PATCH] D18902: X86: Use a callee save register for the swiftself parameter.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 11:29:22 PDT 2016


> On Apr 8, 2016, at 11:26 AM, Matthias Braun <matze at braunis.de> wrote:
> 
> MatzeB added inline comments.
> 
> ================
> Comment at: test/CodeGen/X86/swiftself.ll:2
> @@ -5,1 +1,3 @@
> +; RUN: llc -verify-machineinstrs -mtriple=x86_64-unknown-unknown -o - %s | FileCheck --check-prefix=CHECK --check-prefix=OPT %s
> +; RUN: llc -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown -o - %s | FileCheck %s
> 
> ----------------
> Is it worth testing a calling a convention that does not behave any different for SwiftSelf? We're not testing fastcall or GHC either…

The tests were here so I figured it is important not to regress them :).

> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D18902
> 
> 
> 



More information about the llvm-commits mailing list