[PATCH] D18902: X86: Use a callee save register for the swiftself parameter.
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 8 11:18:36 PDT 2016
qcolombet added inline comments.
================
Comment at: lib/Target/X86/X86FrameLowering.cpp:1889
@@ +1888,3 @@
+ // passed in callee saved registers.
+ bool isKill = !isLiveIn;
+
----------------
Perhaps add that this is conservatively correct but maybe not optimal.
================
Comment at: test/CodeGen/X86/swiftself.ll:2
@@ -5,1 +1,3 @@
+; RUN: llc -verify-machineinstrs -mtriple=x86_64-unknown-unknown -o - %s | FileCheck --check-prefix=CHECK --check-prefix=OPT %s
+; RUN: llc -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown -o - %s | FileCheck --check-prefix=CHECK %s
----------------
mgrang wrote:
> We can get rid of --check-prefix=CHECK
Could you re-add the i386 tests?
Repository:
rL LLVM
http://reviews.llvm.org/D18902
More information about the llvm-commits
mailing list