[PATCH] D18891: [OCaml] Expose the LLVM diagnostic handler

[whitequark via llvm-commits]

whitequark added inline comments.

================
Comment at: test/Bindings/OCaml/linker.ml:21
@@ +20,3 @@
+  Printf.printf
+    "Diagnostic handler called: %s\n" (Llvm.DiagnosticInfo.get_description di)
+
----------------
jketema wrote:
> whitequark wrote:
> > Is this (and elsewhere in `test/`) actually used in tests?
> It's used in the sense that currently the test crashes, because it tries to read invalid bitcode but no handler is installed. Having diagnostic handlers actually fixes the tests updated in this patch.
> 
> It's not used in the sense that there's no `FileCheck` for the printed text. I could make the  handler just be empty instead?
Why not add the check?


http://reviews.llvm.org/D18891