[PATCH] D18820: [llvm-c] Expose LLVMContextGetDiagnostic{Handler, Context}

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 14:47:03 PDT 2016


deadalnix accepted this revision.
deadalnix added a comment.

Small nits, but looks good overall.


================
Comment at: tools/llvm-c-test/diagnostic.c:40
@@ +39,3 @@
+    break;
+
+  }
----------------
Remove empty line

================
Comment at: tools/llvm-c-test/llvm-c-test.h:53
@@ +52,3 @@
+// diagnostic.c
+int llvm_diagnostic_handler(void);
+
----------------
The name is a bit confusing, because this isn't the handler. Maybe llvm_test_diagnostic_handler or something alike.


http://reviews.llvm.org/D18820





More information about the llvm-commits mailing list