[PATCH] Fix formatting and wording of llvm-ranlib error message

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 14:28:31 PDT 2016


LGTM, Thanks.


On 7 April 2016 at 16:27, Yung, Douglas via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> When llvm-ranlib is run without arguments, it prints out the following error
> message:
>
>
>
> llvm-ranlib.exe: llvm-ranlib.exetakes just one archive as argument
>
>
>
> My patch fixes this up a little by adding a space between the
> “llvm-ranlib.exe” and “takes”, as well as adds the word “an” between the
> words “an” and “argument”. With my patch, the error message would look like
> this:
>
>
>
> llvm-ranlib.exe: llvm-ranlib.exe takes just one archive as an argument
>
>
>
> This change is NFC.
>
>
>
> Here is the simple patch:
>
>
>
> Index: tools/llvm-ar/llvm-ar.cpp
>
> ===================================================================
>
> --- tools/llvm-ar/llvm-ar.cpp   (revision 265713)
>
> +++ tools/llvm-ar/llvm-ar.cpp   (working copy)
>
> @@ -760,7 +760,7 @@
>
>
>
> static int ranlib_main() {
>
>    if (RestOfArgs.size() != 1)
>
> -    fail(ToolName + "takes just one archive as argument");
>
> +    fail(ToolName + " takes just one archive as an argument");
>
>    ArchiveName = RestOfArgs[0];
>
>    return performOperation(CreateSymTab, nullptr);
>
> }
>
>
>
> Douglas Yung
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list