[PATCH] D18622: Replace the use of MaxFunctionCount module flag

David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 11:41:38 PDT 2016


davidxl added inline comments.

================
Comment at: include/llvm/ProfileData/ProfileCommon.h:194
@@ +193,3 @@
+    return nullptr;
+  // Computing profile summary for a module involves parsing a fairly large
+  // metadata and could be expensive. We use a simple cache of the last seen
----------------
I suggest doing some compile time measurement before using the caching mechanism. Besides, this won't affect O2 compile time at all.


http://reviews.llvm.org/D18622





More information about the llvm-commits mailing list