[PATCH] D18684: [SCEV] See through op.with.overflow intrinsics

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 09:35:33 PDT 2016


sanjoy added inline comments.

================
Comment at: lib/Analysis/ScalarEvolution.cpp:3841
@@ +3840,3 @@
+
+  for (User *U : CI->users()) {
+    if (auto *EVI = dyn_cast<ExtractValueInst>(U)) {
----------------
regehr wrote:
> I'm a little confused about this loop-- since we're looking for one branch, why do we want the loop here instead of just returning false if the CallInst has more than one user?
We're also accumulating the result projections into `AddVals` (which in retrospect should be called something else, since they're not just additions -- I'll fix that).


http://reviews.llvm.org/D18684





More information about the llvm-commits mailing list