[PATCH] D18438: Calculate __builtin_object_size when pointer depends on a condition

[Strahinja Petrovic via llvm-commits]

spetrovic marked 4 inline comments as done.

================
Comment at: lib/Analysis/MemoryBuiltins.cpp:390
@@ -391,1 +389,3 @@
 
+APInt ObjectSizeOffsetVisitor::getSizeWithOverflow(SizeOffsetType Data) {
+  if (Data.second.slt(0) || Data.first.ult(Data.second))
----------------
george.burgess.iv wrote:
> Is there a reason this method needs to exist on the visitor? Either way, please take `SizeOffsetType` by const&.
This part of code is called few times, and maybe will be called and for phi node case too, so I think it's OK to put it in a method.


Repository:
  rL LLVM

http://reviews.llvm.org/D18438