[PATCH] D18830: [llvm] GVN.cpp: Do not swap when both LHS and RHS are arguments.

[Chandler Carruth via llvm-commits]

chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

Please don't avoid extra work in this way IMO, unless you have a very significant compile time hit due to this.

We have a pervasive reliance on canonicalizing constants to the RHS of binary operations so those should be exceedingly rare anyways. We shouldn't fight that, we should run with it.

My two cents. If Danny, Chad, or others working more on GVN disagree, they can happily override me. =D


Repository:
  rL LLVM

http://reviews.llvm.org/D18830