[PATCH] D18820: [llvm-c] Expose LLVMContextGetDiagnostic{Handler, Context}

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 22:28:36 PDT 2016


deadalnix added a comment.

Overall I'm good with it. I'm not sure test belongs in the echo thing. I would add a new flag to llvm-c-test and just create a new kind of test. That way it would be possible to actually trigger the handler and see if it does what is expected.


http://reviews.llvm.org/D18820





More information about the llvm-commits mailing list