[PATCH] D18841: [InstCombine] Canonicalize icmp instructions based on dominating conditions.

[Balaram Makam via llvm-commits]

bmakam added a comment.

In http://reviews.llvm.org/D18841#393646, @majnemer wrote:

> Is this the best pass for this change to be in? ISTM that something like jump threading would be more appropriate.


I see no reason to only solve this one way. This could be handled at instsimplify or early-cse or jumpthreading or instcombine or gvn. I felt instcombine to be better place because we have dominator tree info  and there already exists a function isSignBitCheck that checks if the comparison only checks the sign bit.


http://reviews.llvm.org/D18841