[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:383
@@ -380,1 +382,3 @@
+    MPM.add(createPGOIndirectCallPromotionPass());
+  }
 
----------------
Why is it running twice in LTO mode?

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:588
@@ -583,1 +587,3 @@
 
+  // Indirect call promotion. (xur)
+  PM.add(createPGOIndirectCallPromotionPass(true));
----------------
What is the meaning of the "xur" here?

================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:534
@@ +533,3 @@
+
+bool PGOIndirectCallPromotion::runOnModule(Module &M) {
+  if (DisableICP)
----------------
Can you implement this in a utility function? I expect the "pass wrapper" to have a dummy runOnModule that would only call the public API.



http://reviews.llvm.org/D17864