[PATCH] D18771: [lld] Add ScriptParserBase class

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 10:40:51 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/LinkerScript.cpp:112
@@ -110,3 +111,3 @@
 
-  void run();
+  void run() final;
 
----------------
I think `final` here is redundant because you marked this class as final.


http://reviews.llvm.org/D18771





More information about the llvm-commits mailing list