[PATCH] D18830: [llvm] GVN.cpp: Do not swap when both LHS and RHS are arguments.

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 10:29:40 PDT 2016


yes.
LGTM

On Wed, Apr 6, 2016 at 10:28 AM, Chad Rosier <mcrosier at codeaurora.org>
wrote:

> mcrosier added a comment.
>
> In http://reviews.llvm.org/D18830#393392, @dberlin wrote:
>
> > I don't believe this case is testable, because line 1904 should swap them
> >  back into the right order anyway.
> >  All this patch will do is avoid extra work.
>
>
> Am I correct in assuming this LGTY, Daniel?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18830
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160406/fbe0c95f/attachment.html>


More information about the llvm-commits mailing list