[polly] r264118 - [ScopInfo] Fix domains after loops.
Tobias Grosser via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 6 10:08:04 PDT 2016
On 04/06/2016 07:01 PM, Michael Kruse wrote:
> 2016-04-04 20:36 GMT+02:00 Tobias Grosser <tobias at grosser.es>:
>> In fact, it might make sense to not bail out early in case
>> -process-unprofitable is set. This will give us more test coverage for the
>> code generator and will also expose the bug Michael has seen independently
>> of which domain we generate. I had some patches that made the code generator
>> robust against such issues. These will not "improve" the modeling, but will
>> prevent the crash.
>
> Do you suggest this change?
>
> --- a/lib/Analysis/ScopInfo.cpp
> +++ b/lib/Analysis/ScopInfo.cpp
> @@ -2918,7 +2918,7 @@ void Scop::init(AliasAnalysis &AA,
> AssumptionCache &AC, ScopDetection &SD,
>
> buildSchedule(SD, LI);
>
> - if (!hasFeasibleRuntimeContext())
> + if (!PollyProcessUnprofitable && !hasFeasibleRuntimeContext())
> return;
>
> updateAccessDimensionality();
Yes, I do.
Best,
Tobias
More information about the llvm-commits
mailing list