[PATCH] D18706: [DWARF] Force a linkage_name on an inlined subprogram's abstract origin

[David Blaikie via llvm-commits]

Seems this makes the flag (dwarf-linkage-names=*) a bit erroneous, no?
Would it be better to trigger this directly off the debugger tuning flag
now & drop the specific named flag?

On Tue, Apr 5, 2016 at 4:06 PM, Paul Robinson via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> probinson added a comment.
>
> In http://reviews.llvm.org/D18706#391801, @probinson wrote:
>
> > Built Clang with Clang 3 times: linkage names Enabled, linkage names
> Disabled but with the patch, linkage names Disabled without the patch (aka:
> all names, some names, no names).
> >  'all names' and 'no names' are the options we have today; this patch
> replaces 'no names' with 'some names.'
>
>
> dblaikie wrote (in email):
>
> > Which option(s) are you referring to here ^ (do we have a flag or
> somesuch that
>
> >  allows enabling/disabling linkage names?)
>
>
> Yes, DwarfDebug.cpp has `-dwarf-linkage-names={Enable,Disable}` which is
> disabled by default when tuning for SCE, otherwise enabled by default.
> This is what `DD->useLinkageNames()` is referring to, in addLinkageName(),
> giving us the all/none options.
> My patch obviously substitutes 'some' for 'none'.
>
>
> http://reviews.llvm.org/D18706
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160406/c1fa75ea/attachment.html>