[PATCH] D18828: [llvm] Minor code cleanups for GVN. NFC.
Aditya Kumar via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 6 08:46:25 PDT 2016
hiraditya added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1896
@@ -1897,1 +1895,3 @@
+ if (isa<Constant>(LHS)
+ || (isa<Argument>(LHS) && !isa<Argument>(RHS) && !isa<Constant>(RHS)))
std::swap(LHS, RHS);
----------------
mcrosier wrote:
> This doesn't appear to be a NFC.
My bad. This change was meant to be a separate patch. I'll remove this.
Thanks for pointing out.
Repository:
rL LLVM
http://reviews.llvm.org/D18828
More information about the llvm-commits
mailing list